7
\$\begingroup\$

Related to a previous question, but sufficiently different that I think it merits its own discussion.

Now that I've hit 2000 rep I have access to some mod tools, which include the ability to approve or reject edits made by users with less than 1000 rep. There are four outstanding, some of them from a while back.

What should we do with edits like this? I don't seem to have the ability to promote them to answers, so the options are to accept them, reject them, or reject them and summarise the changes in a comment so that the original author can incorporate them or not.

\$\endgroup\$
  • \$\begingroup\$ Has this issue been resolved in terms of edits that improve others' solutions? I just passed on a suggested edit that simply reduced the character count in somebody's golfed code. From the comments below, I can't deduce whether the community decided such edits are OK or not OK. Does rejecting an edit allow one to specify the reason why it's being rejected? \$\endgroup\$ – COTO Oct 8 '14 at 18:41
  • 1
    \$\begingroup\$ @COTO, I think the consensus expressed below is that if it was correcting the character count it's ok, but if it was changing the code it isn't. You do get a (very short) custom message to explain the rejection. \$\endgroup\$ – Peter Taylor Oct 8 '14 at 18:43
  • \$\begingroup\$ OK. Will do. Thanks. \$\endgroup\$ – COTO Oct 8 '14 at 18:51
6
\$\begingroup\$

I've found to be trickier on CodeGolf.SE than on other sites.

I'll start by dividing the problem into three groups

  1. change only the character count

    These are relatively easy, just check with George's script.

  2. change the text, but not the solution

    Substantive edits that don't touch the solution are about the same as on other site. Just check that they really do improve the question in terms of grammar, spelling, usage, clarity, etc.

  3. change the solution

    This is the place where I'm stuck. When we were playing on Stack Overflow people generally did not edit each others work, but left helpful comments---your third solution comes down to enforcing that approach.

    I started leaving them under the impression that the authors would be see them and take care of it, but I'm not sure that this is the case.


Aside: The whle topic makes me feel guilty because I've been studiouly ignoring some of these suggested edits.

\$\endgroup\$
  • \$\begingroup\$ On SO people would also create a new answer containing the improvements and mention that this answer was based on so and so's answer. Is there something about this site that is giving people the impression that there should only be one answer for each language? \$\endgroup\$ – gnibbler Sep 22 '11 at 23:53
  • 2
    \$\begingroup\$ I don't really see any point in multiple FooLang answers that all take the same strategy, but I like to see several approaches no matter what languages they are implemented in. \$\endgroup\$ – dmckee Sep 22 '11 at 23:56
5
\$\begingroup\$

Of the three options I've suggested, I favour the third: to add comments summarising the proposed changes for the original authors to deal with. It's not really fair on the people who made the edits, because they won't get any rep, but it's more in line with the way improvements to someone else's answer are proposed in general on this site.

\$\endgroup\$
2
\$\begingroup\$

I've seen a few proposed edits where a second, highly related solution is edited into the same answer below the original.

This can perhaps be OK, or is at least safer, since the original is not touched and there is an "alternate" version which the OP can choose to fold into their original answer via editing?

Dunno, just throwing it out there as an idea, since I didn't see it listed in the other answers here.

\$\endgroup\$

You must log in to answer this question.

Not the answer you're looking for? Browse other questions tagged .